Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port of static content example to Nima webserver #6778

Merged
merged 3 commits into from
May 9, 2023
Merged

Port of static content example to Nima webserver #6778

merged 3 commits into from
May 9, 2023

Conversation

spericas
Copy link
Member

@spericas spericas commented May 5, 2023 •
edited
Loading

Port of static content example to Nima webserver. Added new @ServerTest based test.

@spericas spericas added examples 4.x Version 4.x labels May 5, 2023
@spericas spericas added this to the 4.0.0 milestone May 5, 2023
@spericas spericas self-assigned this May 5, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 5, 2023
@spericas
Fixed checkstyle.
97ccc73 
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
barchetta
barchetta reviewed May 8, 2023
View reviewed changes
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README mentions StaticContentSupport so maybe change that.

@spericas
Replaced StaticContentSupport by StaticContentService.
4652b26 
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas
Copy link
Member Author

spericas commented May 8, 2023

README mentions StaticContentSupport so maybe change that.

Fixed.

barchetta
barchetta approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spericas spericas merged commit 8c0d1fe into helidon-io:main May 9, 2023
@spericas spericas mentioned this pull request May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchetta barchetta barchetta approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

Assignees

@spericas spericas

Labels
4.x Version 4.x examples OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@spericas @barchetta